Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useScrollLock): check first effect #8124

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

SevereCloud
Copy link
Contributor

Описание

При первом рендере выполняется disableScrollLock, из-за чего пользователя может кинуть в 0 позицию, если он прокрутил страницу. Также вызывается лишний reflow

Изменения

Проверяем что это не первый эффект при управлении скролллоком

Release notes

Исправления

  • AppRoot: исправлено отключение блокировки прокрутки при первом рендере

Проверяем что это не первый эффект при управлении скролллоком
@SevereCloud SevereCloud requested a review from a team as a code owner December 26, 2024 17:55
@github-actions github-actions bot added the patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча label Dec 26, 2024
@SevereCloud SevereCloud self-assigned this Dec 26, 2024
@SevereCloud SevereCloud added this to the v7.1.1 milestone Dec 26, 2024
Copy link
Contributor

size-limit report 📦

Path Size
JS 389.46 KB (+0.01% 🔺)
JS (gzip) 118.21 KB (+0.02% 🔺)
JS (brotli) 97.26 KB (-0.02% 🔽)
JS import Div (tree shaking) 1.56 KB (0%)
CSS 342.61 KB (0%)
CSS (gzip) 42.45 KB (0%)
CSS (brotli) 33.82 KB (0%)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

e2e tests

⚠️ Some screenshots were failed. See Playwright Report.

Playwright Report

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.56%. Comparing base (ba6b9c4) to head (eadeddb).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8124   +/-   ##
=======================================
  Coverage   95.55%   95.56%           
=======================================
  Files         398      398           
  Lines       11351    11355    +4     
  Branches     3741     3742    +1     
=======================================
+ Hits        10847    10851    +4     
  Misses        504      504           
Flag Coverage Δ
unittests 95.56% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

👀 Docs deployed

Commit eadeddb

@BlackySoul BlackySoul merged commit d9cbf49 into master Dec 27, 2024
29 checks passed
@BlackySoul BlackySoul deleted the SevereCloud/fix/useScrollLock/check-first-effect branch December 27, 2024 06:08
vkcom-publisher pushed a commit that referenced this pull request Dec 27, 2024
Проверяем что это не первый эффект при управлении скролллоком
@vkcom-publisher
Copy link
Contributor

v7.1.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants