Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Pagination): fix rtl view #8117

Merged
merged 2 commits into from
Dec 26, 2024
Merged

Conversation

EldarMuhamethanov
Copy link
Contributor

  • e2e-тесты
  • Release notes

Описание

Сейчас в компоненте Pagination в режиме rtl иконки стрелок отображаются некорректно

Изменения

При rtl поменял местами иконки стрелок вперед/назад

Release notes

Улучшения

  • Pagination: Поправлено отображение компонента в rtl

Copy link
Contributor

size-limit report 📦

Path Size
JS 389.13 KB (+0.03% 🔺)
JS (gzip) 118.09 KB (+0.03% 🔺)
JS (brotli) 97.32 KB (+0.1% 🔺)
JS import Div (tree shaking) 1.56 KB (0%)
CSS 341.82 KB (0%)
CSS (gzip) 42.32 KB (0%)
CSS (brotli) 33.7 KB (0%)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

e2e tests

⚠️ Some screenshots were failed. See Playwright Report.

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit f784dd1

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.55%. Comparing base (446b1cd) to head (f784dd1).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8117   +/-   ##
=======================================
  Coverage   95.55%   95.55%           
=======================================
  Files         398      398           
  Lines       11326    11339   +13     
  Branches     3731     3736    +5     
=======================================
+ Hits        10822    10835   +13     
  Misses        504      504           
Flag Coverage Δ
unittests 95.55% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EldarMuhamethanov EldarMuhamethanov merged commit 0837a7c into master Dec 26, 2024
29 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/rtl/Pagination branch December 26, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants