Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Avatar): Overlay use ImageBaseOverlay #7984

Merged

Conversation

SevereCloud
Copy link
Contributor

  • Unit-тесты (нужно тащить nextjs)
  • e2e-тесты (не требуется)
  • Дизайн-ревью (не требуется)
  • Документация фичи (не требуется)
  • Release notes

Описание

Next.JS при использовании VKUI без "use client" определяет Avatar.Overlay как undefined и на установке свойства displayName падает с ошибкой

Uncaught TypeError: Cannot set properties of undefined (setting 'displayName')

На деле ошибка Next.JS

Изменения

Используем напрямую функцию ImageBaseOverlay

Release notes

Исправления

  • Поправлена проблема Avatar.Overlay для Next.JS

@SevereCloud SevereCloud requested a review from a team as a code owner November 24, 2024 11:30
Copy link

codesandbox-ci bot commented Nov 24, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Nov 24, 2024

size-limit report 📦

Path Size
JS 385.64 KB (-0.01% 🔽)
JS (gzip) 116.97 KB (+0.01% 🔺)
JS (brotli) 96.2 KB (+0.03% 🔺)
JS import Div (tree shaking) 1.46 KB (0%)
CSS 334.8 KB (0%)
CSS (gzip) 42.35 KB (0%)
CSS (brotli) 33.43 KB (0%)

Copy link

codecov bot commented Nov 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.36%. Comparing base (db19559) to head (daba898).
Report is 15 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7984   +/-   ##
=======================================
  Coverage   95.36%   95.36%           
=======================================
  Files         380      380           
  Lines       11321    11322    +1     
  Branches     3769     3769           
=======================================
+ Hits        10796    10797    +1     
  Misses        525      525           
Flag Coverage Δ
unittests 95.36% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

github-actions bot commented Nov 24, 2024

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Nov 24, 2024

👀 Docs deployed

Commit daba898

@SevereCloud SevereCloud force-pushed the SevereCloud/fix/Avatar/Overlay-use-ImageBaseOverlay branch from 4e391d0 to daba898 Compare November 24, 2024 11:45
@SevereCloud SevereCloud self-assigned this Nov 24, 2024
@SevereCloud SevereCloud added this to the v7.0.0-beta.2 milestone Nov 25, 2024
@SevereCloud SevereCloud merged commit 4af4862 into master Nov 25, 2024
28 checks passed
@SevereCloud SevereCloud deleted the SevereCloud/fix/Avatar/Overlay-use-ImageBaseOverlay branch November 25, 2024 13:50
@vkcom-publisher
Copy link
Contributor

v7.0.0-beta.2 🎉

@inomdzhon inomdzhon modified the milestones: v7.0.0-beta.2, v7.0.0 Dec 2, 2024
@vkcom-publisher
Copy link
Contributor

v7.0.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants