Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add mergeStyle #7979

Merged
merged 3 commits into from
Nov 22, 2024
Merged

Conversation

SevereCloud
Copy link
Contributor

  • Unit-тесты
  • e2e-тесты (не требуется)
  • Дизайн-ревью (не требуется)
  • Документация фичи
  • Release notes (не требуется)

Описание

В свойствах стилей часто используются спреды, которые копируют значения объектов

Изменения

Добавляем функцию mergeStyle которая уменьшает количество компирований

Release notes

Sorry, something went wrong.

@SevereCloud SevereCloud requested a review from a team as a code owner November 22, 2024 13:30
Copy link
Contributor

github-actions bot commented Nov 22, 2024

size-limit report 📦

Path Size
JS 385.65 KB (+0.01% 🔺)
JS (gzip) 116.97 KB (+0.02% 🔺)
JS (brotli) 96.18 KB (-0.01% 🔽)
JS import Div (tree shaking) 1.46 KB (0%)
CSS 334.8 KB (0%)
CSS (gzip) 42.35 KB (0%)
CSS (brotli) 33.43 KB (0%)

Copy link

codesandbox-ci bot commented Nov 22, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Nov 22, 2024

e2e tests

Playwright Report

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.36%. Comparing base (99acad5) to head (18c2c5e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7979      +/-   ##
==========================================
+ Coverage   95.35%   95.36%   +0.01%     
==========================================
  Files         379      380       +1     
  Lines       11314    11321       +7     
  Branches     3773     3769       -4     
==========================================
+ Hits        10788    10796       +8     
+ Misses        526      525       -1     
Flag Coverage Δ
unittests 95.36% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@EldarMuhamethanov EldarMuhamethanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

github-actions bot commented Nov 22, 2024

👀 Docs deployed

Commit cdb3d89

BlackySoul
BlackySoul previously approved these changes Nov 22, 2024
@BlackySoul BlackySoul mentioned this pull request Nov 22, 2024
3 tasks
BlackySoul
BlackySoul previously approved these changes Nov 22, 2024
@inomdzhon
Copy link
Contributor

не измерял случайно с этой оптимизацией и без?

@SevereCloud
Copy link
Contributor Author

SevereCloud commented Nov 22, 2024

не измерял случайно с этой оптимизацией и без?

Перепилил с учетом постоянного использования только двух объектов

Бенч

Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🚀

@SevereCloud SevereCloud merged commit db19559 into master Nov 22, 2024
28 checks passed
@SevereCloud SevereCloud deleted the SevereCloud/refactor/add-mergeStyle branch November 22, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants