Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v5] fix(dynamicTokens): rm universal selector #6507

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

SevereCloud
Copy link
Contributor

@SevereCloud SevereCloud commented Feb 2, 2024

Описание

Удаляем универсальный селектор из-за проблем с памятью. Выпиливаем переопределение цвета обводки

@SevereCloud SevereCloud requested a review from a team as a code owner February 2, 2024 11:51
@SevereCloud SevereCloud changed the base branch from master to v5 February 2, 2024 11:52
@SevereCloud SevereCloud marked this pull request as draft February 2, 2024 11:53
@SevereCloud SevereCloud marked this pull request as ready for review February 2, 2024 11:53
@github-actions github-actions bot added patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча v5 Автоматизация: PR продублируется в ветку v5 labels Feb 2, 2024
@SevereCloud SevereCloud added patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча and removed patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча v5 Автоматизация: PR продублируется в ветку v5 labels Feb 2, 2024
Copy link

codesandbox-ci bot commented Feb 2, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d5a4e6b:

Sandbox Source
VKUI TypeScript Configuration

Copy link
Contributor

github-actions bot commented Feb 2, 2024

size-limit report 📦

Path Size
JS 371.5 KB (0%)
JS (gzip) 111.89 KB (0%)
JS (brotli) 90.86 KB (0%)
JS import Div (tree shaking) 2.74 KB (0%)
CSS 286.13 KB (+0.11% 🔺)
CSS (gzip) 36.68 KB (+0.2% 🔺)
CSS (brotli) 29.16 KB (+0.11% 🔺)

Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

github-actions bot commented Feb 2, 2024

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Feb 2, 2024

👀 Docs deployed

Commit d5a4e6b

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7f1888d) 80.60% compared to head (6e6f68a) 80.74%.
Report is 14 commits behind head on v5.

❗ Current head 6e6f68a differs from pull request most recent head d5a4e6b. Consider uploading reports for the commit d5a4e6b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##               v5    #6507      +/-   ##
==========================================
+ Coverage   80.60%   80.74%   +0.14%     
==========================================
  Files         314      314              
  Lines       10796    10849      +53     
  Branches     3364     3383      +19     
==========================================
+ Hits         8702     8760      +58     
+ Misses       2094     2089       -5     
Flag Coverage Δ
unittests 80.74% <ø> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SevereCloud SevereCloud force-pushed the SevereCloud/fix/dynamic-tokens branch from 25e9255 to d5a4e6b Compare February 2, 2024 12:14
@github-actions github-actions bot added the v5 Автоматизация: PR продублируется в ветку v5 label Feb 2, 2024
@SevereCloud SevereCloud removed the v5 Автоматизация: PR продублируется в ветку v5 label Feb 2, 2024
@github-actions github-actions bot added the v5 Автоматизация: PR продублируется в ветку v5 label Feb 2, 2024
@SevereCloud SevereCloud removed the v5 Автоматизация: PR продублируется в ветку v5 label Feb 5, 2024
@SevereCloud SevereCloud force-pushed the SevereCloud/fix/dynamic-tokens branch from 6e6f68a to d5a4e6b Compare February 7, 2024 09:48
@github-actions github-actions bot added the v5 Автоматизация: PR продублируется в ветку v5 label Feb 7, 2024
@SevereCloud SevereCloud removed the v5 Автоматизация: PR продублируется в ветку v5 label Feb 8, 2024
@SevereCloud SevereCloud self-assigned this Feb 8, 2024
@SevereCloud SevereCloud added this to the v5.10.1 milestone Feb 8, 2024
@SevereCloud SevereCloud merged commit 4abb835 into v5 Feb 8, 2024
49 checks passed
@SevereCloud SevereCloud deleted the SevereCloud/fix/dynamic-tokens branch February 8, 2024 09:42
@inomdzhon inomdzhon changed the title fix(dynamicTokens): rm universal selector [v5]fix(dynamicTokens): rm universal selector Feb 28, 2024
@inomdzhon inomdzhon changed the title [v5]fix(dynamicTokens): rm universal selector [v5] fix(dynamicTokens): rm universal selector Feb 28, 2024
@vkcom-publisher
Copy link
Contributor

v5.10.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants