Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: only run tests for non-draft PRs #195

Merged
merged 1 commit into from
Sep 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/molecule_playbooks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,16 @@ on:
pull_request:
branches:
- main
types:
- opened
- reopened
- synchronize
- ready_for_review

jobs:

define_scenarios:
if: github.event.pull_request.draft == false
runs-on: ubuntu-latest
steps:
- name: Checkout
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/molecule_roles.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,16 @@ on:
pull_request:
branches:
- main
types:
- opened
- reopened
- synchronize
- ready_for_review

jobs:

get_changed_roles:
if: github.event.pull_request.draft == false
runs-on: ubuntu-latest
outputs:
matrix: ${{ steps.changed-roles.outputs.all_changed_files }}
Expand Down
2 changes: 2 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ In short:
5. Submit a pull request from that branch to the main branch of the master repository.
6. If you receive feedback, make changes on your desktop and push to your branch on GitHub: the pull request will update automatically.

**Note**: in order not to needlessly trigger test workflows, please convert your PR to a draft while you are still working on it. When ready, mark your PR as "ready for review". This will ensure tests are run.

## Style guides

### Branch naming conventions
Expand Down