-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: client identification headers #186
Conversation
@@ -116,3 +116,35 @@ func TestContains(t *testing.T) { | |||
} | |||
}) | |||
} | |||
|
|||
func TestGetConnectionId(t *testing.T) { | |||
for i := 0; i < 100; i++ { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we run it 100 times? is there something specific about this SDK compared to the others where we test in only once?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to avoid accidentally passing some tests, because implementation of "make everything random" could accidentally create a version and variant with correct values.
Identification headers consistent with other Unleash SDKs.
Fixes issue/1-3271