Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Test fixes develop 2.0.0 #3301

Closed
wants to merge 15 commits into from
Closed

ci: Test fixes develop 2.0.0 #3301

wants to merge 15 commits into from

Conversation

michalChrobot
Copy link
Collaborator

@michalChrobot michalChrobot commented Feb 17, 2025 •
edited
Loading

This PR addresses some test failures in new CI definition

  1. Code Coverage failure--> This test was failing because packed package couldn't be find because the path was wrongly pointing to different place. This is fixed by this PR bu utilizing upm-pvp in place of upm-ci
  2. minimalproject standards failure
  3. testproject-tools-integration standards failure

@michalChrobot michalChrobot self-assigned this Feb 17, 2025
@michalChrobot michalChrobot deleted the test-fixes-develop-2.0.0 branch February 18, 2025 10:32
@michalChrobot
Copy link
Collaborator Author

New PR was created --> #3302 (I closed this one because I needed to revert some things)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miniwolf miniwolf Awaiting requested review from miniwolf miniwolf will be requested when the pull request is marked ready for review miniwolf is a code owner

@NoelStephensUnity NoelStephensUnity Awaiting requested review from NoelStephensUnity NoelStephensUnity will be requested when the pull request is marked ready for review NoelStephensUnity is a code owner

@fluong6 fluong6 Awaiting requested review from fluong6 fluong6 will be requested when the pull request is marked ready for review fluong6 is a code owner

@EmandM EmandM Awaiting requested review from EmandM EmandM will be requested when the pull request is marked ready for review EmandM is a code owner

Assignees

@michalChrobot michalChrobot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@michalChrobot