Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added farcaster admin conenction #630

Merged
merged 1 commit into from
Sep 21, 2024
Merged

added farcaster admin conenction #630

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions authentication/admin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
TwitterConnection,
UserProfile,
Wallet,
FarcasterConnection,
)


Expand Down Expand Up @@ -53,9 +54,15 @@ class EnsConnectionAdmin(admin.ModelAdmin):
search_fields = ["user_profile__username", "user_wallet_address"]


class FarcasterConnectionAdmin(admin.ModelAdmin):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Consider creating a base class for connection admin models to reduce code duplication.

The FarcasterConnectionAdmin class is very similar to other connection admin classes like EnsConnectionAdmin. Creating a base class could help reduce duplication and make it easier to add new connection types in the future.

class BaseConnectionAdmin(admin.ModelAdmin):
    list_display = ["pk", "user_profile", "user_wallet_address"]
    search_fields = ["user_profile__username", "user_wallet_address"]

class FarcasterConnectionAdmin(BaseConnectionAdmin):
    pass

list_display = ["pk", "user_profile", "user_wallet_address"]
search_fields = ["user_profile__username", "user_wallet_address"]


admin.site.register(Wallet, WalletAdmin)
admin.site.register(UserProfile, ProfileAdmin)
admin.site.register(BrightIDConnection, BrightIDConnectionAdmin)
admin.site.register(GitcoinPassportConnection, GitcoinPassportConnectionAdmin)
admin.site.register(TwitterConnection, TwitterConnectionAdmin)
admin.site.register(ENSConnection, EnsConnectionAdmin)
admin.site.register(FarcasterConnection, FarcasterConnectionAdmin)
Loading