Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: update solc to 0.8.28 #445

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

worm-emoji
Copy link

Description of changes

This pull request updates the version of solc used from 0.8.26 to 0.8.28. This is desired because Solidity 0.8.27 adds a variety of improvements to via IR builds, which v4 requires.

I understand if this won't be merged but figured I would attempt anyway so I don't have to use my fork of this repo :)

@hensha256
Copy link
Contributor

Yeah sorry this wont be merged! Interested in how much it imprves gas though? Did you run forge test --isolate and push the gas snapshot changes?

@worm-emoji
Copy link
Author

Just checked in the snapshots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants