Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HookMiner #434

Merged
merged 13 commits into from
Feb 12, 2025
Merged

HookMiner #434

merged 13 commits into from
Feb 12, 2025

Conversation

saucepoint
Copy link
Collaborator

A minimal library for mining hook addresses in forge test or forge script

@saucepoint saucepoint requested a review from snreynolds January 23, 2025 22:02
marktoda
marktoda reviewed Feb 2, 2025
View reviewed changes
Copy link
Contributor

@marktoda marktoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests are failing but think this would be super useful to merge

@saucepoint saucepoint requested a review from marktoda February 2, 2025 20:46
snreynolds
snreynolds reviewed Feb 3, 2025
View reviewed changes
Copy link
Member

@snreynolds snreynolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually found the Deploy script that uses hook miner to be quite useful as well, can we PR that in as well?

@saucepoint saucepoint merged commit c391435 into main Feb 12, 2025
5 checks passed
@saucepoint saucepoint deleted the hookminer branch February 12, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snreynolds snreynolds snreynolds approved these changes

@marktoda marktoda Awaiting requested review from marktoda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saucepoint @snreynolds @marktoda