feat(ur-sdk): migrating out of range -> in range or out of range -> opposite side out of range #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ayoakala
reviewed
Jan 30, 2025
sdks/universal-router-sdk/test/forge/MigratorCallParameters.t.sol
Outdated
Show resolved
Hide resolved
Ayoakala
reviewed
Jan 30, 2025
dianakocsis
changed the title
hensha256
reviewed
Feb 14, 2025
| options.v4AddLiquidityOptions.batchPermit.permitBatch.spender == universalRouterAddress, | ||
| 'INVALID_SPENDER' | ||
| ) | ||
| planner.addCommand(CommandType.PERMIT2_PERMIT_BATCH, [ |
There was a problem hiding this comment.
its only ever going to be 1 currency i think? so using batch is unnecessary?
There was a problem hiding this comment.
permitBatch is already a param of v4AddLiquidityOptions so i figured i would just keep it instead of adding another one?
| assertEq(v4PositionManager.balanceOf(RECIPIENT), 1, "V4 NOT MINTED"); | ||
| } | ||
|
|
||
| function test_migrate_v3OutOfRangeIn1_v4OutOfRangeIn1() public { |
There was a problem hiding this comment.
do we need tests for unwrapping/wrapping at all?
Graphite Automations"Request reviewers once CI passes on sdks monorepo" took an action on this PR • (02/21/25)2 reviewers were added and 1 assignee was added to this PR based on Siyu Jiang (See-You John)'s automation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Scope
Please title your PR according to the following types and scopes following conventional commits:
fix(SDK name):will trigger a patch versionchore(<type>):will not trigger any release and should be used for internal repo changes<type>(public):will trigger a patch version for non-code changes (e.g. README changes)feat(SDK name):will trigger a minor versionfeat(breaking):will trigger a major version for a breaking changeDescription
[Summary of the change, motivation, and context]
How Has This Been Tested?
[e.g. Manually, E2E tests, unit tests, Storybook]
Are there any breaking changes?
[e.g. Type definitions, API definitions]
If there are breaking changes, please ensure you bump the major version Bump the major version (by using the title
feat(breaking): ...), post a notice in #eng-sdks, and explicitly notify all Uniswap Labs consumers of the SDK.(Optional) Feedback Focus
[Specific parts of this PR you'd like feedback on, or that reviewers should pay closer attention to]
(Optional) Follow Ups
[Things that weren't addressed in this PR, ways you plan to build on this work, or other ways this work could be extended]