Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display blogpost tags #37

Merged
merged 5 commits into from
Mar 3, 2023
Merged

Display blogpost tags #37

merged 5 commits into from
Mar 3, 2023

Conversation

podliashanyk
Copy link
Contributor

Tags are displayed following @lunkwill42 suggestion in #35

Closes #35

@podliashanyk podliashanyk self-assigned this Jan 20, 2023
@lunkwill42
Use bootstrap labels for tags
3ce4576 
Also, be less verbose for seeing users.
lunkwill42
lunkwill42 requested changes Jan 25, 2023
View reviewed changes
Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a suggestion to style the tags as bootstrap "labels".

Not too sure about the contrast of this styling, so I'm leaving it up to you to evaluate it :)

@podliashanyk podliashanyk merged commit 2bdecd5 into migrate-blog Mar 3, 2023
@lunkwill42 lunkwill42 deleted the display-blogpost-tags branch March 3, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johannaengland johannaengland johannaengland approved these changes

@hmpf hmpf Awaiting requested review from hmpf

@stveit stveit Awaiting requested review from stveit

@lunkwill42 lunkwill42 Awaiting requested review from lunkwill42

Assignees

@podliashanyk podliashanyk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@podliashanyk @lunkwill42 @johannaengland