Skip to content
This repository has been archived by the owner on Feb 11, 2025. It is now read-only.

Make user menu selectors more reusable #200

Merged
merged 3 commits into from
Oct 24, 2024
Merged

Make user menu selectors more reusable #200

merged 3 commits into from
Oct 24, 2024

Conversation

podliashanyk
Copy link
Contributor

No description provided.

@podliashanyk
Drop id attribute in theme name tag
bc1e191 
Makes it possible to include several theme selectors on the same page
@podliashanyk
Drop is attribute in datetime name tag
e270318
@podliashanyk
Drop redundant attributes on datetime selector
c58ef54 
The whole view is refreshed on datetime format update
@podliashanyk podliashanyk requested review from a team October 23, 2024 11:08
@podliashanyk podliashanyk self-assigned this Oct 23, 2024
@podliashanyk podliashanyk added the polish Nice to have label Oct 23, 2024
@podliashanyk podliashanyk mentioned this pull request Oct 23, 2024
Merged
lunkwill42
lunkwill42 approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (and works, too)

@podliashanyk podliashanyk merged commit b781dff into main Oct 24, 2024
2 checks passed
@podliashanyk podliashanyk deleted the make-user-menu-selectors-more-reusable branch October 24, 2024 11:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunkwill42 lunkwill42 lunkwill42 approved these changes

@elfjes elfjes elfjes approved these changes

Assignees

@podliashanyk podliashanyk

Labels
polish Nice to have
Projects
HTMXify Argus
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@podliashanyk @lunkwill42 @elfjes