Skip to content
This repository has been archived by the owner on Feb 11, 2025. It is now read-only.

Add E4 rules to ruff #197

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Add E4 rules to ruff #197

merged 1 commit into from
Oct 28, 2024

Conversation

johannaengland
Copy link
Contributor

Codebase already fulfills these rules.

Tagging as discussion to invite discussion if/which of these rules we want.

Reference: https://docs.astral.sh/ruff/rules/#error-e

Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we get into this class of linter violations: Won't they already be flagged by attempting to run black or ruff formatting of the codebase?

@johannaengland
Copy link
Contributor Author

Once we get into this class of linter violations: Won't they already be flagged by attempting to run black or ruff formatting of the codebase?

I tested this by adding import os, sys and then running ruff format . and it was not changed.

@lunkwill42
Copy link
Member

I tested this by adding import os, sys and then running ruff format . and it was not changed.

My bad. I tried to google what the E4 group of violations mean, and was left with the impression that they were all kinds of syntax errors: But now I'm thinking I must have found a reference from an entirely different tool, because it does not match up at all with the ruff docs we just looked.

Please disregard my earlier comment, I'm all for this.

@johannaengland johannaengland merged commit 936f44c into main Oct 28, 2024
3 checks passed
@johannaengland johannaengland deleted the linting/add-e4-rules branch October 28, 2024 11:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants