Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump python and postgres versions when running Argus in docker #586

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

podliashanyk
Copy link
Contributor

@podliashanyk podliashanyk commented Oct 15, 2024

Using python 3.8 leads to ERROR: Package 'argus-server' requires a different Python: 3.8.20 not in '>=3.9'.

Closes #587, #588

@podliashanyk podliashanyk added the bug Something is not working as expected label Oct 15, 2024
@podliashanyk podliashanyk requested a review from a team October 15, 2024 08:34
@podliashanyk podliashanyk self-assigned this Oct 15, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.34%. Comparing base (8403776) to head (c7064d6).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #586   +/-   ##
=======================================
  Coverage   57.34%   57.34%           
=======================================
  Files          86       86           
  Lines        3692     3692           
  Branches      839      839           
=======================================
  Hits         2117     2117           
  Misses       1566     1566           
  Partials        9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@hmpf hmpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We run on 3.10 i production so I don't see why we shouldn't do that here as well

@podliashanyk
Copy link
Contributor Author

We run on 3.10 i production so I don't see why we shouldn't do that here as well

Have tested on python 3.10. It seems to require some additional upgrades. It fails with django.db.utils.NotSupportedError: PostgreSQL 13 or later is required (found 12.20)..

@hmpf
Copy link
Contributor

hmpf commented Oct 15, 2024

Worth doing. How do you run postgres?

@podliashanyk podliashanyk force-pushed the bump-python-version-in-server-dockerfile branch from 667ddf1 to c7064d6 Compare October 16, 2024 06:43
Copy link

@podliashanyk podliashanyk changed the title Run argus server on python 3.9 in docker Bump python and postgres versions when running Argus in docker Oct 16, 2024
@podliashanyk podliashanyk requested review from hmpf and a team October 16, 2024 06:48
@hmpf hmpf merged commit f90dd59 into master Oct 17, 2024
3 of 4 checks passed
@hmpf hmpf deleted the bump-python-version-in-server-dockerfile branch October 17, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update python (to 3.10) in docker
4 participants