Add high contrast functionality to timestamp #697
Conversation
metpy/plots/_util.py
Outdated
|
|
||
| Returns | ||
| ------- | ||
| `matplotlib.text.Text` | ||
| The `matplotlib.text.Text` instance created | ||
|
|
||
| """ | ||
| if high_contrast: | ||
| text_args = {'color' : 'white'} |
jrleeman
force-pushed
the
path_effects
branch
2 times, most recently
from
708fa04 to
dab774f
Compare
metpy/plots/_util.py
Outdated
| @@ -6,6 +6,7 @@ | |||
| from datetime import datetime | |||
| import posixpath | |||
|
|
|||
| from matplotlib import patheffects | |||
There was a problem hiding this comment.
We usually do this as:
import matplotlib.patheffects as mpatheffectsThere was a problem hiding this comment.
Will change here, but in that case should probably change all the workshop material as well as it all uses the current method: https://github.com/Unidata/unidata-python-workshop/blob/master/notebooks/Satellite_Data/Working%20with%20Satellite%20Data.ipynb
metpy/plots/_util.py
Outdated
|
|
||
| if high_contrast: | ||
| # Make the text stand out even better using matplotlib's path effects | ||
| outline_effect = [patheffects.withStroke(linewidth=2, foreground='black')] |
There was a problem hiding this comment.
Might be able to just include in text_args as path_effects=[patheffects.withStroke(linewidth=2, foreground='black')].
That might simplify things a little.
There was a problem hiding this comment.
I like it as it'll let users specify custom path effects if they so desire.
metpy/plots/_util.py
Outdated
| if not time: | ||
| time = datetime.utcnow() | ||
| timestr = datetime.strftime(time, 'Created: %Y-%m-%dT%H:%M:%SZ') | ||
| return ax.text(x, y, timestr, ha=ha, transform=ax.transAxes, **kwargs) | ||
| text = ax.text(x, y, timestr, ha=ha, transform=ax.transAxes, **text_args) |
There was a problem hiding this comment.
Any reason not to just do:
return ax.text(...)
|
This should be good to go now. Ping me when #692 is ready to go and I'll re-review and merge. |
dopplershift
added
Type: Enhancement
Closes #610 - Had to do some kwarg manipulation to keep the default black text when not in high contrast mode.