Add default limits to the skew-T plot #196
Conversation
dopplershift
added
Type: Enhancement
dopplershift
removed
the
Status: Need Info
dopplershift
modified the milestones:
Fall 2016 Release (0.4),
Winter 2017 Release (0.5)
jrleeman
force-pushed
the
SkewT_Limits
branch
from
45148dd to
71ac4e0
Compare
|
Removed the limits in the examples. Toying with making the limit setting unit aware and making sure we aren't drawing outside of the bounds. |
examples/plots/Skew-T_Layout.py
Outdated
|
|
||
| # Add the relevant special lines | ||
| skew.plot_dry_adiabats() | ||
| skew.plot_moist_adiabats() | ||
| skew.plot_mixing_lines() | ||
|
|
||
| # Good bounds for aspect ratio | ||
| skew.ax.set_xlim(-30, 40) |
There was a problem hiding this comment.
If we remove this, does the plot still look good?
There was a problem hiding this comment.
I'm going to say no, no it doesn't. At least not until we figure out the problems with aspect ratio.
|
At some point this needs a rebase. |
jrleeman
force-pushed
the
SkewT_Limits
branch
from
b32a030 to
561fc25
Compare
|
In light of discussion, it would be better to draw the fiducial lines properly so that they will re-render when limits are changed, plot is panned, etc. This would just be a bandaid, so I'll close it and we can rethink the problem. |
Codecov Report
@@ Coverage Diff @@
## master #196 +/- ##
==========================================
- Coverage 97.26% 97.24% -0.03%
==========================================
Files 54 54
Lines 4281 4283 +2
==========================================
+ Hits 4164 4165 +1
- Misses 117 118 +1
Continue to review full report at Codecov.
|
Adds default limits to the skew-T plot to address the most common encounter of issue #195. This fix could still be an issue if the user draws the special fiducial lines and then resets the limits. That would require a more dynamic fix or setting the limits before drawing the lines.