Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contributors List #1525

Merged
merged 3 commits into from
Dec 10, 2020
Merged

Contributors List #1525

merged 3 commits into from
Dec 10, 2020

Conversation

MinchinWeb
Copy link
Contributor

Description Of Changes

Further to #1522, this updates the list of contributors to date. I've also added myself to this list, in anticipation of this being merged.

Checklist

Further Notes

I supposed this could be automated in the future, but I haven't dug into the CI pipeline to figure out what would be needed to make that happen.

For future reference, the base data can be pulled from Git:

git shortlog -s -n

It might make sense to add a note to CONTRIBUTING.md to add your name to this list, but I don't see an obvious place to do so.

Hope this is helpful!

@CLAassistant
Copy link

CLAassistant commented Oct 4, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@MinchinWeb
Copy link
Contributor Author

It's failing because of something generating the documentation, but it's not something I changed, so I'm not sure what's up. I tried to get sphinx running locally, but couldn't get it working (Proj version 0.0.0 is installed, but cartopy requires at least version 4.9.0. but the latest version on PyPI is 0.2.0...). Suggestions?

@MinchinWeb MinchinWeb changed the title Contributors Contributors List Oct 4, 2020
@MinchinWeb MinchinWeb mentioned this pull request Oct 4, 2020
Open
@MinchinWeb
Copy link
Contributor Author

This maybe should close #383 as well.

@dopplershift dopplershift linked an issue Oct 5, 2020 that may be closed by this pull request
Contributors list #383
Open
@dopplershift
Copy link
Member

Pre-release doc build is known to fail right now (no way to mark a GitHub Action check as such) so that's not a worry.

I'm not sure I want contributors to really need to deal with this--it just seems like another hurdle.

What I'd really like to do is, as part of the doc build process, generate the list automatically and have it included as a thanks page in the docs. Feel up to that?

@MinchinWeb
Copy link
Contributor Author

What I'd really like to do is, as part of the doc build process, generate the list automatically and have it included as a thanks page in the docs. Feel up to that?

Maybe?? I'm trying to figure how to do this without getting lost in "yak shaving"...

@MinchinWeb
Copy link
Contributor Author

MinchinWeb commented Nov 10, 2020 •
edited
Loading

Hi @dopplershift I may get to this, but it's on my "sometime" list... (i.e. it's not scheduled, and I really have no idea when it might happen)

@dopplershift dopplershift added Area: Docs Affects documentation Type: Maintenance Updates and clean ups (but not wrong) labels Dec 9, 2020
@dopplershift dopplershift added this to the 1.0 milestone Dec 9, 2020
@dopplershift dopplershift merged commit 495061a into Unidata:master Dec 10, 2020
@MinchinWeb MinchinWeb deleted the contributors branch December 11, 2020 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift approved these changes

@dcamron dcamron Awaiting requested review from dcamron

Assignees
No one assigned
Labels
Area: Docs Affects documentation Type: Maintenance Updates and clean ups (but not wrong)
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.

Contributors list Generate list of code contributors
3 participants
@MinchinWeb @CLAassistant @dopplershift