Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skewt subroutines updated to handle non-celcius #1165

Closed
wants to merge 2 commits into from
Closed

skewt subroutines updated to handle non-celcius #1165

wants to merge 2 commits into from

Conversation

jibbals
Copy link

@jibbals jibbals commented Sep 16, 2019

Description Of Changes

Updated the moist adiabats, dry adiabats, and the mixing line subroutines
to use the xaxis units. These routines originally used degrees celcius
even if the xaxis was not degrees celcius. This caused lines to be
plotted wrongly on any other units.

Checklist

Closes #1155
I don't know how to add tests

  • Tests added
  • Fully documented

Updated the moist adiabats, dry adiabats, and the mixing line subroutines
to use the xaxis units. These routines originally used degrees celcius
even if the xaxis was not degrees celcius. This caused lines to be
plotted wrongly on any other units.

A similar issue may occur if units other than mbar are used..

Resolves: #1155
@CLAassistant
Copy link

CLAassistant commented Sep 16, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ jibbals
❌ Jesse Greenslade


Jesse Greenslade seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jibbals
Copy link
Author

jibbals commented Sep 16, 2019

I will close the pull request, and try again when I have time to figure out the process.

@jibbals jibbals closed this Sep 16, 2019
@zbruick
Copy link
Contributor

zbruick commented Sep 16, 2019

Let us know if you have any questions about the process! The original code in this PR looked good I think. It just looks like you had commits from two different user accounts, which the CLA was complaining about then.

The tests are a little trickier for this PR, since they'll be image tests. You can find information on our page here. However, we can also help write the tests and push to your future PR, if you allow write access from maintainers when you open the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

skewT subplots assume celcius without a warning
4 participants