-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add functionality to declarative plotting #1026
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general this is going in the right direction. I think there are a few things that need cleaning up, and I'm concerned that the changed test isn't failing.
Huge 👍 on the addition, thanks for putting this together.
311e75e
to
129265d
Compare
Don't know why the test_declarative_contour_options is failing - passes on my machine. |
eb925d4
to
f4afbc5
Compare
d7250c1
to
5653e90
Compare
An initial attempt to address some of the functionality desired in issue #1016 by adding contour labels, colorbar, colorfill plots, and linetypes to contours. Added a test and a few elements to other tests to hopefully get coverage of the new elements.
For both labels and colobar I would love to add more options to how they plot, but I don't currently understand the traitlets well enough to figure it out. This is a start anyway.
Only issue I have had is when I plot contours with an ImagePlot, the spacing of the contour labels gets HUGE! But I was able to fix the issue when I reversed the order in the panel call.
This works
But this does not work as desired
Unable to fully diagnose why the ordering changes the impact, but it does.
Looking for any feedback on this PR.