Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GINIFile #2636

Open
dopplershift opened this issue Aug 25, 2022 · 0 comments
Open

Remove GINIFile #2636

dopplershift opened this issue Aug 25, 2022 · 0 comments
Labels
Area: IO Pertains to reading data Type: API Change Changes to how existing functionality works
Milestone

Comments

@dopplershift
Copy link
Member

Once #2635 is merged, we have two supported ways of reading GINI data:

  1. GiniFile (and xarray support by passing that instance to open_dataset)
  2. The xarray v2 backend support that can directly open the file

Since xarray is our primary data model, we should drop (1) (this is obviously an API break). At some point we should formally deprecate the use of GiniFile (for the small population that might be using archived GINI files).

When removing, we can substantially refactor the GINI support. At this time, all product information available previously in the direct reader (e.g. things in the prod_dec attribute) should be made available as attributes. We can also consider making the data field lazy loaded (though that's tricky due to the zlib frame-based compression in the products, so maybe not).

@dopplershift dopplershift added Area: IO Pertains to reading data Type: API Change Changes to how existing functionality works labels Aug 25, 2022
@dopplershift dopplershift added this to the 2.0 milestone Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: IO Pertains to reading data Type: API Change Changes to how existing functionality works
Projects
Status: No status
Development

No branches or pull requests

1 participant