Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider dropping codecov #2489

Open
dopplershift opened this issue May 21, 2022 · 4 comments
Open

Consider dropping codecov #2489

dopplershift opened this issue May 21, 2022 · 4 comments
Labels
Area: Infrastructure Pertains to project infrastructure (e.g. CI, linting) Type: Enhancement Enhancement to existing functionality

Comments

@dopplershift
Copy link
Member

Codecov is occasionally a source of weird CI failures due to dropped reports. We could accomplish the same thing by combining all our testing into a single workflow with a single end job that combines the reports and checks the coverage. (Unsure if/how we could check 100% running tests.) We could also have it upload the HTML report for coverage as an artifact.

Inspired by this blog post and workflow.
@dopplershift dopplershift added Area: Infrastructure Pertains to project infrastructure (e.g. CI, linting) Type: Enhancement Enhancement to existing functionality labels May 21, 2022
@dopplershift
Copy link
Member Author

Looks like Ned Batchelder posted about the tests thing: https://nedbatchelder.com/blog/202111/coverage_goals.html

@dopplershift
Copy link
Member Author

Also worth noting: https://github.com/nedbat/coveragepy/blob/ad824b4585c88d0a153dd248f4585084dea33189/.github/workflows/coverage.yml#L218-L221

@dcamron
Copy link
Member

dcamron commented May 25, 2022

Regardless of specifically dropping codecov, I do like the idea of moving towards a single testing+coverage report, particularly now with actions summaries. If moving towards that also happens to remove the need for codecov and its occasional hiccups, then I'm on board.

@dopplershift
Copy link
Member Author

Stumbled across this action that might make this easier: https://github.com/py-cov-action/python-coverage-comment-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Infrastructure Pertains to project infrastructure (e.g. CI, linting) Type: Enhancement Enhancement to existing functionality
Projects
Python
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dopplershift @dcamron