Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contours descriptor should allow range objects #2122

Closed
sgdecker opened this issue Sep 22, 2021 · 1 comment · Fixed by #2152
Closed

contours descriptor should allow range objects #2122

sgdecker opened this issue Sep 22, 2021 · 1 comment · Fixed by #2152
Labels
Area: Plots Pertains to producing plots Type: Enhancement Enhancement to existing functionality
Milestone

Comments

@sgdecker
Copy link
Contributor

sgdecker commented Sep 22, 2021

Another issue (referenced below) also discusses the contours setting, but in a slightly different way. What I'm looking for here is the ability to not have to coerce range objects to lists. While forcing the user to use list() isn't that terrible, it is a pain point that doesn't seem like it should be necessary.

So,
fills.contours = range(0, 40, 4)
should work, where fills is a (Filled)ContourPlot object.

  • I'm not a huge fan of the current "contours" set-up. For GEMPAK users they have been used to giving a contour interval if
    only a single number is given, not the number of contours to plot. Would be great to have the ability to set just a contour
    interval or a tuple of (cint, start, stop) or something similar

Originally posted by @kgoebber in #1016 (comment)

@dopplershift
Copy link
Member

Should be pretty easy to add Instance(range) to the trait in ContourTraits as well as add a validator to call list on the range there so that the subclasses have the right value available.

@dopplershift dopplershift added Area: Plots Pertains to producing plots Type: Enhancement Enhancement to existing functionality labels Sep 22, 2021
@dopplershift dopplershift added this to the 1.2.0 milestone Sep 22, 2021
@kgoebber kgoebber mentioned this issue Oct 14, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Plots Pertains to producing plots Type: Enhancement Enhancement to existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants