-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Spec] Add tags for online music databases #19
Comments
Let me quickly change the lyrics into a single note in one sentence, and suddenly I get best score on the online leaderboard. Maybe combining use of the MBID (for local highscores) and the lyrics' hash (for online leaderboard) could work. |
This kind of cheating is probably also possible on API level. I mean, some API needs to be exposed so users can upload their new high score. And I don't know how one should verify that the uploaded score and song id is not fake. So, I would not try to prevent people from cheating in the first place. |
Not quite sure how the Hiscores are done now, as for performous we only have a local database, not a live one. I think the idea is nice, but as from the format view i think it's pretty bad since we'd tie ourselves to musicbrainz id's whilst it might be possible to make it more generic? |
I support the idea. 👍 |
I support @marwin89 idea to make it generic! Who can say for sure that this website will life forever? Do we need a list of DBs that should be supported? |
I agree, the field name should be generic. For the format, I suggest to use a single header field with URL query parameter syntax, i.e. This has the advantage that the parameters can be parsed with existing libs for parsing URLs.
I don't think so. IMO this is an implementation detail of the player. It could be a config setting, whitelist, or something else. Which DBs are supported should not be part of the spec (I argue the same for the #WEBSITE tag). Similarly, the spec also does not define which audio formats are supported because this would not make sense. |
SUMMARYSo here is a summary for this issue up tillnow. We add this tag in version 1.1.0:
The description in the spec (website) is:
|
2nd SUMMARY / VOTE NOW 📈 ✋So here is the second summary for this issue. We are close to a final result. Please vote for this issue till 31th oct 2023 with emoticon 🎉 / 🚀 / ❤️ . 🚀 A: #DBARTIST, #DBRECORDING, #DBRELEASE Why these tags?
Spec doesn't define which db to use. 🚀 AWe add these tags to the next version v.1.1.0 / v2023 #DBARTIST:https://musicbrainz.org/artist/ffd9d946-518f-4e66-800f-994c26bf24d5 🎉 B:We add these tags to the next version v.1.1.0 / v2023 #DATAARTIST:https://musicbrainz.org/artist/ffd9d946-518f-4e66-800f-994c26bf24d5 The description in the spec (website) will be something like:
|
I am for the tag names in Maybe use a separate tag for which Api used? So, the APP can build the URL themselves and also migrate it to a newer API version.
For musicbrainz the Artist URL will then look like this: https://musicbrainz.org/ws/2/artist/ffd9d946-518f-4e66-800f-994c26bf24d5 |
@achimmihca Yes, it is possible on API-level, but no one has done this on API level the past couple of years, despite the communication not even having used TLS. The key part is that doing cheating on API level requires some software dev skills and a bit of time, while copy+pasting some ID in a text file can easily be done by most 10 years old kids. Thus imho this DBRELEASE is not suitable as an identifier except if your goal is to show additional information ingame for this song using (for example) musicbrainz api. For online high scores it imho is not suitable. |
Let's think about that again. Do we really need the DB Link? If you are honest, a well-defined .txt that has all the info about the song is enough to find it with any API. |
True. Ok then, I am fine to close this issue as "won't implement". BTW: @marwin89 thanks for your summaries, I find these pretty helpful. |
SUMMARY / FINAL RESULTS 🏁Thanks for the discussion about MUSICDB-feature. Here is the result:
😄 good to hear that. I'll continue this moderation. |
Suggestion
I suggest to add an official header field for MusicBrainz IDs (MBID).
Note that MusicBrainz is free only for non-commercial use.
I remember that UltraSinger is already using MusicBrainz to add information about newly created songs.
Use case
Extra info/examples/attachments
Examples
The text was updated successfully, but these errors were encountered: