(release/v1.1.1): code cleanup #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Going to be extracting out a lot of functionality to slim this down
This is just to avoid a new dependency via express and handles some pre-processing for me by default. Not the prettiest but its also not the worst thing I've ever made
This centralises all the interaction with x32 into a single class with methods to interact with them. Uses some hacky stuff for error handling which may not be necessary but should roughly handle everything it needs to do. Logging has been included throughout
These routes are just aliases around a simple state function call. Everything is routed and parameters are checked through the micro router
Slimmed down and extracted out of the index
This is much nicer and should make a much more maintainable system. Will be going through and adding some more comments soon and that should conclude the initial cleanup
This should be the end of the changes required to fix up #6
Vitineth
added
enhancement
|
I've not looked at the code in great detail but my feedback points are:
|
|
New updates have been released and this has been deployed on the pi @wlabarron - version has been changed, you might have better luck with |
|
Can confirm that |
|
@wlabarron astounded you don't just have an x32 lying around on your desk to use! As soon as we've got a run on a real desk this will get merged in to make main match the version deployed to the pi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change shouldn't have much of an impact on the functionality of the system, in general it has just divided the code up to extract out the HTTP server into a more modular structure and changed slightly how the interactions work (ie x32 devices are now identified by name rather than ip/port combinations in the web requests). To accomplish this, one technically breaking change has had to be made in which the
namekey of thex32devices in the config is now required and constrained to alphanumeric with-_. This makes it simpler when using it in the web requests and as they are now identified by name, these names must be unique. This is marked as a patch change as this will not affect the existing configurations in use.Addresses #6