Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update callouts on front page #1414

Merged
merged 6 commits into from
Feb 5, 2024

Conversation

lparsons
Copy link
Member

@lparsons lparsons commented Feb 1, 2024

Description

This PR updates the callouts on the front page to highlight our now regular newsletters, the new career guide, and the current DEI initiative for Black History Month. The plan is to change the third card back to "Community Funds" in March.

Per a converstaion with @exoticDFT and @cosden

Checklist:

  • I have previewed changes locally or with CircleCI (runs when PR is created)
  • I have completed any content reviews, such as getting input from relevant working groups. If no, please note this and wait to post the PR to the #website channel until the content has been settled.

When you are ready for a technical review/merge, post the for the link for the PR in the US-RSE Slack (#website) to ask for reviewers.

Copy link
Member

@exoticDFT exoticDFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the one link, I think this looks good. @cosden / @USRSE/steering-committee are we still good with these three events being on the main landing page for the month of February?

@lparsons lparsons requested a review from exoticDFT February 1, 2024 19:59
@exoticDFT exoticDFT marked this pull request as ready for review February 1, 2024 20:23
@lparsons lparsons force-pushed the black-history-month-frontpage branch from 4598de7 to 56f06b2 Compare February 5, 2024 20:25
@lparsons lparsons force-pushed the black-history-month-frontpage branch 2 times, most recently from 4406371 to dd3be27 Compare February 5, 2024 20:57
@lparsons lparsons force-pushed the black-history-month-frontpage branch from dd3be27 to 5f3b5a5 Compare February 5, 2024 21:01
Copy link
Member

@exoticDFT exoticDFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'm going to merge, but noted about the linting format change.

Comment on lines +43 to +69
exclude_patterns: "supercomputing.org,\
https://pace.gatech.edu,\
https://www.linkedin.com,\
jobs.colorado.edu,zoom.us,\
danielskatz.org,\
usrse.github.io.wiki.git,\
ornl.gov,\
jobs.bnl.gov,\
https://www.rd-alliance.org/,\
https://uwhires.admin.washington.edu/,\
https://careers.umich.edu/,\
https://twitter.com/us_rse,\
https://twitter.com/us_rse/status/1447622175133945860,\
https://twitter.com/iancosden/status/1122937311644323841,\
https://bitcon.blacksintechnology.net/"

# Exclude these files from the checker
exclude_files: README.md,docs/events.md,docs/tests_ci.md,docs/local_previews.md,SocialNetworks.yml,map.yml,_config.yml,tests/test_,.github/workflows,_posts/newsletters/
exclude_files: "README.md,\
docs/events.md,\
docs/tests_ci.md,\
docs/local_previews.md,\
SocialNetworks.yml,\
map.yml,\
_config.yml,\
tests/test_,\
.github/workflows,\
_posts/newsletters/"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making note in case others would like to do this another way. This is definitely better than one really long comma-separated string.

@exoticDFT exoticDFT merged commit 694b8f1 into USRSE:main Feb 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants