Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove errant trailing backslash on svg path #503

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

robertdeniszczyc2
Copy link
Contributor

What?

There is a trailing backslash in the govuk-template file on the svg path line, which causes console error:

Error: <path> attribute d: Expected path command, "…5 7.9-.8 12.3-.8\\".

This change removes the error.

Why?

How?

Testing?

Screenshots (optional)

Anything Else? (optional)

Check list

  • I have reviewed my own pull request for linting issues (e.g. adding new lines)
  • I have written tests (if relevant)
  • I have created a JIRA number for my branch
  • I have created a JIRA number for my commit
  • I have followed the chris beams method for my commit https://cbea.ms/git-commit/
    here is an example commit
  • Ensure workflow jobs are passing especially tests
  • I will squash the commits before merging

@robertdeniszczyc2 robertdeniszczyc2 linked an issue Feb 26, 2025 that may be closed by this pull request
Copy link
Contributor

@sulthan-ahmed sulthan-ahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for highlighting @robertdeniszczyc2 it looks good, we just need to publish a beta package and get this tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trailing backslash causes error in svg path
2 participants