EPP-146 amend CHANGE SUBSTANCES page #76
Open
+215
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaolaDMadd-Pro
force-pushed
the
EPP-146-amend-CHANGE-SUBSTANCES
branch
from
2b1769b to
9980156
Compare
PaolaDMadd-Pro
changed the title
vivekkumar-ho
requested changes
Feb 28, 2025
- add some logic to redirect to the correct path if answer is no it will check agains the previous pages answers - add change-substances.html - add fields in index.js, fields.json and pages.json and fiels/index.js - add summary-data-section.js - add some path to next page
PaolaDMadd-Pro
force-pushed
the
EPP-146-amend-CHANGE-SUBSTANCES
branch
from
71294bf to
70fb661
Compare
I rebased again . what do you think about the behaviour? |
PaolaDMadd-Pro
force-pushed
the
EPP-146-amend-CHANGE-SUBSTANCES
branch
from
f2ac836 to
809e157
Compare
- improved check-answer-behaviour.js - reorder summary data sections as per figma - tide up fields.json - correct missing field label in page.json - add new behaviour to change-home-address and amend-details-pages - add unit test
PaolaDMadd-Pro
force-pushed
the
EPP-146-amend-CHANGE-SUBSTANCES
branch
from
809e157 to
dc98b3b
Compare
william-gu-hof
requested changes
Mar 3, 2025
| if (allFieldsNo) { | ||
| return res.redirect(`${req.baseUrl}/no-details-amend`); | ||
| } else if (req.form.values[currentField] === 'no' && !allFieldsNo | ||
| && currentField === 'amend-change-substances-options') { |
There was a problem hiding this comment.
The above logic doesn't seem to cover AC6 on the ticket?
There was a problem hiding this comment.
Since AC6 contains more requirement, can you be more specific? which condition is not covered?
- update index.js add fork only for negative path since positive is by default - update tests check-answer-redirect.spec.js as well as check-answer-redirect.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
as per jira ticket EPP-146 Create a CHANGE SUBSTANCES page
Why?
to allow the user to be directed to change substance flow or to skip this step
How?
Testing?
n/a manual
Screenshots (optional)
Anything Else? (optional)
Check list
here is an example commit