Merge pull request UE4SS-RE#780 from UE4SS-RE/fix-opengl-window-not-closing

narknon · web-flow · commit c0a8d4cb259d · 2025-02-06T10:12:01.000-05:00
Added missing glfw cleanup calls
diff --git a/UE4SS/src/GUI/GLFW3_OpenGL3.cpp b/UE4SS/src/GUI/GLFW3_OpenGL3.cpp
@@ -86,6 +86,8 @@ namespace RC::GUI
 
     auto Backend_GLFW3_OpenGL3::cleanup() -> void
     {
+        glfwDestroyWindow(m_window);
+        glfwTerminate();
     }
 
     auto Backend_GLFW3_OpenGL3::create_device() -> bool
diff --git a/assets/Changelog.md b/assets/Changelog.md
@@ -184,6 +184,9 @@ Fixed `ModsFolderPath` in `UE4SS-settings.ini` not working ([UE4SS #609](https:/
 
 Fixed `attempt to index a nil value (global 'NewController')` error in `SplitScreenMod` ([UE4SS #729](https://github.com/UE4SS-RE/RE-UE4SS/pull/729)) 
 
+Fixed the GUI not closing properly with CTRL + O when OpenGL is enabled in
+`UE4SS-settings.ini`. ([UE4SS #780](https://github.com/UE4SS-RE/RE-UE4SS/pull/780))
+
 ### Live View 
 Fixed the "Write to file" checkbox not working for functions in the `Watches` tab ([UE4SS #419](https://github.com/UE4SS-RE/RE-UE4SS/pull/419)) 
 

Original file line number	Diff line number	Diff line change
`@@ -86,6 +86,8 @@ namespace RC::GUI`
`86`	`86`
`87`	`87`	`auto Backend_GLFW3_OpenGL3::cleanup() -> void`
`88`	`88`	`{`
	`89`	`+ glfwDestroyWindow(m_window);`
	`90`	`+ glfwTerminate();`
`89`	`91`	`}`
`90`	`92`
`91`	`93`	`auto Backend_GLFW3_OpenGL3::create_device() -> bool`