Ticket # 147 - About us page layout #166
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
src/components/BoardAlumniCard.tsx
Outdated
| <div className="flex flex-col items-center mb-8"> | ||
| {image && ( | ||
| <div className="w-32 h-32 overflow-hidden rounded-full mb-4"> | ||
| <img |
There was a problem hiding this comment.
This image is missing a text alternative. This is a problem for people using screen readers.
lakshman8664
force-pushed
the
about_us_layout
branch
2 times, most recently
from
dce0ee2 to
008cbee
Compare
olliepai
requested changes
Nov 7, 2024
lakshman8664
force-pushed
the
about_us_layout
branch
from
008cbee to
f6a5ef8
Compare
lakshman8664
force-pushed
the
about_us_layout
branch
from
f6a5ef8 to
1421ed0
Compare
Modified the image size in "upcoming events" section. Created a new card for this instead of modifying the GenericCard component. |
| <div className="border-2 border-black rounded-2xl p-6 flex flex-col items-center text-center shadow-md w-full"> | ||
| {/* Circular Profile Picture */} | ||
| <div className="w-24 h-24 overflow-hidden rounded-full mb-4 border-2 border-black"> | ||
| <img className="object-cover w-full h-full" src={image} /> |
There was a problem hiding this comment.
This image is missing a text alternative. This is a problem for people using screen readers.
|
new structure for "About Us" page added (since the latest Figma changes) |
lakshman8664
force-pushed
the
about_us_layout
branch
from
811d9b1 to
0549f38
Compare
…scription after Projects title
…oard Teams. Descriptions extended in 'Opportunities' and 'How Do We Operate?' sections to fit wireframe. Updated 'Opportunities' section to match new wireframe with images and descriptions.
| return ( | ||
| <div className={`border-2 border-black-300 rounded-lg p-6 flex flex-col h-full transition-transform duration-300 hover:scale-105 ${className}`}> | ||
| <div className="flex flex-col items-center w-full space-y-4 group flex-grow"> | ||
| <img src={imgSrc} className="h-24 w-24 py-4 drop-shadow-lg group-hover:scale-110 transition ease-in-out duration-300" /> |
There was a problem hiding this comment.
This image is missing a text alternative. This is a problem for people using screen readers.
| return ( | ||
| <div className={`group p-4 border-2 border-black-300 rounded-lg p-6 transition-transform duration-300 hover:scale-105 ${className}`}> | ||
| <div className={`flex justify-center items-center space-x-4 rounded-xl drop-shadow-lg ${bgClassName} ${reverse ? 'flex-row-reverse space-x-reverse' : ''}`}> | ||
| <img src={imgSrc} className="h-[100px] md:h-[100px] py-4 drop-shadow-xl" /> |
There was a problem hiding this comment.
This image is missing a text alternative. This is a problem for people using screen readers.
| // return ( | ||
| // <div className="border-2 border-black-300 rounded-lg p-6 transition-transform duration-300 hover:scale-105"> | ||
| // <div className="flex flex-col items-center w-full space-y-4"> | ||
| // <img src={imgSrc} className="h-24 w-24 py-4 drop-shadow-lg" /> |
There was a problem hiding this comment.
This image is missing a text alternative. This is a problem for people using screen readers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
finished page structure using existing components.
About, Board Member Highlights, and Alumni Recollections sections filled with static data
Filled Upcoming Events and Past Events (dynamic data) with dummy values temporarily