-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename base images #14
Comments
@joelostblom the reasoning at this point was because R and Python implied RStudio and Jupyterlab (and then postgres would imply pgadmin). I think switching to just I am happy for a change to be made that encompasses both, perhaps a I do have two concerns (that are definitely addressable) with making a change:
Given your findings in #15 and the updates in PrairieLearn/PrairieLearn#10713, it might be worth overhauling the current setup and instead of basing on the PL images (and working with their quirks), we switch to an IDE base and then have languages installed on top. So instead of the current workflow being:
We treat languages as extensions instead of linked to an IDE:
|
I don't fully understand this. I'm thinking we will have a |
My bad, I misread your original comment as referring to the course images as they are currently labelled Then when I was explaining the second half of my response I was thinking of doing what you originally suggested without realising I misunderstood your suggestion 😅 To make sure we are on the same page then I would assume the workflow would be:
|
Perfect! That's what I have in mind too! |
On hold until PL has base implemented |
@ZacWarham What do you think of renaming the base images to
-jupyterlab
and-rstudio
instead of-python
and-r
? Not the most urgent thing to do so hold off until you have more time, but in 531 I am exploring using jupyterlab for both python and R so the new naming would make more sense there.The text was updated successfully, but these errors were encountered: