fix: import emoji-mart dynamically like (#950) #1491
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nperez0111
force-pushed
the
dynamic-import-emoji-mart
branch
from
b6f27ab to
931c5dd
Compare
nperez0111
force-pushed
the
dynamic-import-emoji-mart
branch
from
931c5dd to
a1a6cf9
Compare
| let emojiMart: typeof import("emoji-mart") | undefined; | ||
| let emojiData: EmojiMartData | undefined; | ||
|
|
||
| async function loadEmojiMart() { |
There was a problem hiding this comment.
Decided to make both of these the same, and also made them Node.js safe
| ? (emojiDataModule.default as EmojiMartData) | ||
| : (emojiDataModule as EmojiMartData); | ||
|
|
||
| emojiMart.init({ data: emojiData }); |
There was a problem hiding this comment.
I think this needs an await
There was a problem hiding this comment.
Hm, wasn't clear that it was async in the docs https://github.com/missive/emoji-mart?tab=readme-ov-file#-emoji-component , but won't hurt to await
| }> | ||
| | undefined; | ||
|
|
||
| // Temporary fix for https://github.com/missive/emoji-mart/pull/929 |
There was a problem hiding this comment.
fyi, the reason data was global and could be a promise would be to prevent duplicate loads when loadEmojiMart is called twice in a row.
Didn't help readability and it might be a premature optimization so I'm ok with the new version as long as we don't see this causing any issues
There was a problem hiding this comment.
Ah, I can de-dupe easily. I'll pull that in.
This resolves the emoji-mart import dynamically just like what was done in #950 to resolve the same issue.