Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: forward refs to the final component #1485

Merged
merged 2 commits into from
Mar 4, 2025
Merged

fix: forward refs to the final component #1485

merged 2 commits into from
Mar 4, 2025

Conversation

nperez0111
Copy link
Contributor

@nperez0111 nperez0111 commented Mar 4, 2025

There was a console error being logged because we were passing a ref without using forward ref

image

Copy link

vercel bot commented Mar 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
blocknote ✅ Ready (Inspect) Visit Preview Mar 4, 2025 2:47pm
blocknote-website 🛑 Canceled (Inspect) Mar 4, 2025 2:47pm

@nperez0111 nperez0111 merged commit 743e8aa into main Mar 4, 2025
4 of 6 checks passed
@nperez0111 nperez0111 deleted the forward-refs branch March 4, 2025 14:42
@vercel vercel bot temporarily deployed to Preview – blocknote-website March 4, 2025 14:44 Inactive
@YousefED
Copy link
Collaborator

YousefED commented Mar 4, 2025

Nice catch. React 19 actually gives warnings with forwardRef btw (because it's deprecated). I'm not sure what the best practice is to make it work well on both 18+19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants