Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws-eks-asg-rolling-update-handler): Add option to create PodMonitor #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kilitr
Copy link

@kilitr kilitr commented Nov 13, 2023

Summary

this enables usage of PodMonitor CustomResource in kube-prometheus-stack and it opens the possibility of port-forwarding.

In my opinion this shouldnt be notable in existing deployments.

Checklist

  • Tested and/or added tests to validate that the changes work as intended, if applicable.
  • Updated documentation in README.md, if applicable.

@kilitr
Copy link
Author

kilitr commented Nov 13, 2023

I need this in order to use a PodMonitor like this:

apiVersion: monitoring.coreos.com/v1
kind: PodMonitor
metadata:
  name: rolling-update-handler-metrics
spec:
  selector:
    matchLabels:
      app.kubernetes.io/name: aws-eks-asg-rolling-update-handler
  podMetricsEndpoints:
  - port: metrics

Copy link
Owner

@TwiN TwiN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you bump the version in the Chart.yaml file?

@kilitr kilitr force-pushed the master branch 2 times, most recently from d2413a1 to 64e92fc Compare January 31, 2024 09:13
@kilitr
Copy link
Author

kilitr commented Jan 31, 2024

sure :)

@kilitr kilitr force-pushed the master branch 3 times, most recently from 4b8e14e to 4153b57 Compare March 26, 2024 13:45
@kilitr kilitr requested a review from TwiN March 26, 2024 13:45
@kilitr kilitr changed the title add spec.containers[].ports[] for METRICS_PORT env feat(aws-eks-asg-rolling-update-handler): Add option to create PodMonitor Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants