Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add discernible classes and names to stubs #111

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

saxamaphone69
Copy link

Following my comment from #108, I attempted a PR.

I'm sure there is a better way to make the HTML than innerHTML, but it's a start.

@TuxedoTako
Copy link
Owner

I'm sure there is a better way to make the HTML than innerHTML, but it's a start.

subject here is user generated, and nameBlock contains whatever username is used. This is vulnerable to XSS. Even when the user isn't trying to XSS, putting a < in one of those fields will break how it's displayed.

@saxamaphone69
Copy link
Author

I guess as well, if stubs should look like
Subject - Anonymous (where .stub-subject needs ::after { content: ' - '; }
or the margin-right: 1ch that's present now, with no ' - ' breaking up the subject/name.

@TuxedoTako TuxedoTako merged commit e41cefe into TuxedoTako:project-XT Oct 11, 2024
@TuxedoTako
Copy link
Owner

I'm curious to see what you'll use these classes for.

@saxamaphone69
Copy link
Author

Probably nothing, but glad that the option is there. Appreciate it again.

@saxamaphone69 saxamaphone69 deleted the patch-10 branch January 15, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants