Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/11439 sample app has more queries #40

Open
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

mdorford
Copy link

@mdorford mdorford commented Jun 7, 2024

SampleApp now displays all the queries (and also DepositMulti) that a User in RestService has access to.
SampleApp shows the User everything that they need to know to run the query in Postman.
In example,

Is the request a POST or a GET?
What is the body (if the request is a POST)?
What are the query parameters?
What is the purpose of the request?
SampleApp also returns the results and a User can enter their own parameters.
A few nice touches:

values for SwitchSpecVersion are radio buttons so that a User cannot enter a value incorrectly
The endDate in the default bodies of Posts is set to "new Date()" so that a User will get SOME results
The default bodies will return some-but-not-too-many results. For instance, the Wzdx GET for radius from a specific location uses a point that is south of San Francisco so that it will almost certainly get scores of results but won't get THOUSANDS. (It returns thousands if I choose a point inside San Francisco.)
The button and the Results textarea show up above the Body section so that a User will know that the query has returned results
Here is the link to the 11439
https://dev.azure.com/trihydro/SDX/_workitems/edit/11439/

@mdorford mdorford requested review from payneBrandon and rgelmis June 7, 2024 21:20
@pmonington
Copy link
Contributor

This looks good to me, though the only concern I have is the yarn file and the dependencies. The pushed conflict is from upgrading some dependencies to avoid certain vulnerabilities. A yarn upgrade and yarn install will likely need to be ran after resolving the merge conflicts.

@mdorford
Copy link
Author

This looks good to me, though the only concern I have is the yarn file and the dependencies. The pushed conflict is from upgrading some dependencies to avoid certain vulnerabilities. A yarn upgrade and yarn install will likely need to be ran after resolving the merge conflicts.

Fixed. Merged the yarn.lock file so it is using the yarn.lock file from your update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants