diff --git a/provider/common/util.go b/provider/common/util.go index c52679f..99b9ba7 100644 --- a/provider/common/util.go +++ b/provider/common/util.go @@ -148,7 +148,7 @@ func GetIdFromResponse(responseStr string, graphQlResponseKey string) (string, e } responseData, ok := response["data"].(map[string]interface{}) if !ok { - return "", fmt.Errorf("some error eccorred while fetching response") + return "", fmt.Errorf("some error occurred while fetching response") } updatedId, _ := responseData[graphQlResponseKey].(map[string]interface{})["id"].(string) return updatedId, nil diff --git a/provider/data_classification/resource_data_sets.go b/provider/data_classification/resource_data_sets.go index 586ab0e..c3228dd 100644 --- a/provider/data_classification/resource_data_sets.go +++ b/provider/data_classification/resource_data_sets.go @@ -37,6 +37,9 @@ func ResourceDataSetsRule() *schema.Resource { func ResourceDataSetsRuleCreate(rData *schema.ResourceData, meta interface{}) error { name := rData.Get("name").(string) + if name == "" { + return fmt.Errorf("non empty string required") + } description := rData.Get("description").(string) iconType := rData.Get("icon_type").(string) createQuery := GetDatSetQuery("", name, description, iconType) @@ -48,7 +51,7 @@ func ResourceDataSetsRuleCreate(rData *schema.ResourceData, meta interface{}) er log.Printf("This is the graphql response %s", responseStr) id, err := common.GetIdFromResponse(responseStr, "createDataSet") if err != nil { - return fmt.Errorf("error %s", err) + return fmt.Errorf("%s", err) } rData.SetId(id) return nil @@ -91,7 +94,7 @@ func ResourceDataSetsRuleUpdate(rData *schema.ResourceData, meta interface{}) er log.Printf("This is the graphql response %s", responseStr) updatedId, err := common.GetIdFromResponse(responseStr, "updateDataSet") if err != nil { - return fmt.Errorf("error %s", err) + return fmt.Errorf("%s", err) } rData.SetId(updatedId) return nil @@ -102,7 +105,7 @@ func ResourceDataSetsRuleDelete(d *schema.ResourceData, meta interface{}) error query := fmt.Sprintf(DELETE_DATA_SET_QUERY, id) _, err := common.CallExecuteQuery(query, meta) if err != nil { - return fmt.Errorf("error %s", err) + return fmt.Errorf("%s", err) } d.SetId("") return nil diff --git a/provider/provider.go b/provider/provider.go index ea4e35a..032e4e2 100644 --- a/provider/provider.go +++ b/provider/provider.go @@ -4,6 +4,7 @@ import ( "github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema" "github.com/traceableai/terraform-provider-traceable/provider/common" "github.com/traceableai/terraform-provider-traceable/provider/custom_signature" + "github.com/traceableai/terraform-provider-traceable/provider/data_classification" "github.com/traceableai/terraform-provider-traceable/provider/dlp" "github.com/traceableai/terraform-provider-traceable/provider/enumeration" "github.com/traceableai/terraform-provider-traceable/provider/label_management" @@ -78,9 +79,9 @@ func Provider() *schema.Provider { "traceable_custom_signature_testing": custom_signature.ResourceCustomSignatureTestingRule(), // "traceable_api_exclusion_rule": ResourceApiExclusionRule(), // "traceable_agent_token": ResourceAgentToken(), - // "traceable_data_classification_rule": data_classification.ResourceDataClassification(), - // "traceable_data_classification_overrides": data_classification.ResourceDataClassificationOverrides(), - // "traceable_data_sets": data_classification.ResourceDataSetsRule(), + "traceable_data_classification_rule": data_classification.ResourceDataClassification(), + "traceable_data_classification_overrides": data_classification.ResourceDataClassificationOverrides(), + "traceable_data_sets": data_classification.ResourceDataSetsRule(), }, DataSourcesMap: map[string]*schema.Resource{ // "traceable_notification_channels": DataSourceNotificationChannel(),