Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for getting additional pricing details #3

Open
TomSeldon opened this issue Jul 14, 2017 · 0 comments
Open

Add support for getting additional pricing details #3

TomSeldon opened this issue Jul 14, 2017 · 0 comments

Comments

@TomSeldon
Copy link
Owner

TomSeldon commented Jul 14, 2017

Aside from the event price (already available), there are additional prices for things such as:

Car:

  • Extra driver
  • Passenger
  • Helmet hire
  • Tuition
  • Garage hire

Bike:

  • Tyre warmers
  • Tuition

These details are not available from the event list page, and instead the detail page needs to be scraped. This is costly to do when getting all events (as each one would require another request). The number of requests would go from 1, to n+1 (where n is the number of events).

Possibilities:

Add getEventDetails (eventId: number, vehicleType: VehicleType) method for getting further details for an event. This is complicated further by needing to know whether it's a car or bike event. The detail URLs for each vehicle type are different, yet both work. For example:

The same event is accessible by both car and bike URLs, though information (such as above pricing details) are omitted if the wrong URL is used.

I'm not sure what else is available on the detail view that is not available on the event list, so perhaps getAdditionalPrices would be a better method name.

Edit: Additional information that would of use would be the event description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant