Issue#242 perf: add allowance pre-check to transferFrom() #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CT77777
force-pushed
the
Issue#242_perf_transferFrom
branch
from
1806ea5 to
b8a78dc
Compare
CT77777
force-pushed
the
Issue#242_perf_transferFrom
branch
from
b8a78dc to
0285974
Compare
|
@CT77777 did you compare the gas costs of the 2 implementations? because the purpose here is to save gas with the unchecked arithmetic operation, but given the implementation you propose i doubt it saves gas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add pre-check allowance before complicated identity and compliance verification.
It saves gas if transaction is reverted due to insufficient allowance.