From a3e1938f8d75a77cfb51c82c5c2e9b33b78e2e82 Mon Sep 17 00:00:00 2001 From: "ali.arbak" Date: Tue, 10 Sep 2024 16:59:18 +0300 Subject: [PATCH 1/3] Add preset completed event to max balance module --- CHANGELOG.md | 6 ++++++ contracts/compliance/modular/modules/MaxBalanceModule.sol | 3 +++ test/compliances/module-max-balance.test.ts | 6 ++++-- 3 files changed, 13 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 074ef788..a3891be9 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,12 @@ # Change Log All notable changes to this project will be documented in this file. +## [4.1.5] + +### Added + +- Added **PresetCompleted** event to MaxBalanceModule, which is triggered when the presetCompleted function is called. + ## [4.1.4] ### Added diff --git a/contracts/compliance/modular/modules/MaxBalanceModule.sol b/contracts/compliance/modular/modules/MaxBalanceModule.sol index 53751a47..2d39116d 100644 --- a/contracts/compliance/modular/modules/MaxBalanceModule.sol +++ b/contracts/compliance/modular/modules/MaxBalanceModule.sol @@ -92,6 +92,8 @@ contract MaxBalanceModule is AbstractModuleUpgradeable { event IDBalancePreSet(address indexed _compliance, address indexed _id, uint256 _balance); + event PresetCompleted(address indexed _compliance); + /// errors error MaxBalanceExceeded(address _compliance, uint256 _value); @@ -184,6 +186,7 @@ contract MaxBalanceModule is AbstractModuleUpgradeable { } _compliancePresetStatus[_compliance] = true; + emit PresetCompleted(_compliance); } /** diff --git a/test/compliances/module-max-balance.test.ts b/test/compliances/module-max-balance.test.ts index 73d37199..13a94166 100644 --- a/test/compliances/module-max-balance.test.ts +++ b/test/compliances/module-max-balance.test.ts @@ -234,8 +234,10 @@ describe('Compliance Module: MaxBalance', () => { const context = await loadFixture(deployComplianceFixture); const complianceModule = await ethers.deployContract('MaxBalanceModule'); - await complianceModule.connect(context.accounts.deployer).presetCompleted(context.suite.compliance.address); - + const tx = await complianceModule.connect(context.accounts.deployer).presetCompleted(context.suite.compliance.address); + await expect(tx) + .to.emit(complianceModule, 'PresetCompleted') + .withArgs(context.suite.compliance.address); expect(await complianceModule.canComplianceBind(context.suite.compliance.address)).to.be.true; }); }); From c5c4dd72d4e44d15910c2b5d0f3b23a74bd773fc Mon Sep 17 00:00:00 2001 From: "ali.arbak" Date: Tue, 10 Sep 2024 17:04:02 +0300 Subject: [PATCH 2/3] Fix lint --- test/compliances/module-max-balance.test.ts | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/test/compliances/module-max-balance.test.ts b/test/compliances/module-max-balance.test.ts index 13a94166..0453485d 100644 --- a/test/compliances/module-max-balance.test.ts +++ b/test/compliances/module-max-balance.test.ts @@ -235,9 +235,7 @@ describe('Compliance Module: MaxBalance', () => { const complianceModule = await ethers.deployContract('MaxBalanceModule'); const tx = await complianceModule.connect(context.accounts.deployer).presetCompleted(context.suite.compliance.address); - await expect(tx) - .to.emit(complianceModule, 'PresetCompleted') - .withArgs(context.suite.compliance.address); + await expect(tx).to.emit(complianceModule, 'PresetCompleted').withArgs(context.suite.compliance.address); expect(await complianceModule.canComplianceBind(context.suite.compliance.address)).to.be.true; }); }); From eeaadbba44fb75e3f96e31ff61d2f65aa1960e4c Mon Sep 17 00:00:00 2001 From: "ali.arbak" Date: Tue, 10 Sep 2024 17:15:27 +0300 Subject: [PATCH 3/3] Update package version --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 0ef2ea2a..029ecf50 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@tokenysolutions/t-rex", - "version": "4.1.4", + "version": "4.1.5", "description": "A fully compliant environment for the issuance and use of tokenized securities.", "main": "index.js", "directories": {