Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable fullscreen/PiP toggle buttons depending on which is active #1

Open
TimOliver opened this issue Apr 8, 2017 · 0 comments
Open

Comments

@TimOliver
Copy link
Owner

TimOliver commented Apr 8, 2017

At the moment, some strange behaviour occurs if PiP mode is enabled, and then you click the 'fullscreen' button, or vice versa.

Sometimes it works fine, sometimes the entire page dies and needs to be reloaded.

The easiest way to help avoid this issue would be to detect what state the video is playing (Whether fullscreen, or in PiP) and then disable the button for the other mode while it is active.

I don't know when I'll get more time to work on this, so a pull request would be greatly appreciated. :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant