Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interface to extension #35

Merged
merged 9 commits into from
Dec 13, 2024
Merged

Add interface to extension #35

merged 9 commits into from
Dec 13, 2024

Conversation

gjmooney
Copy link
Collaborator

@gjmooney gjmooney commented Dec 13, 2024

Adds an interface to the extension to provide type safety and auto completion on the host page. Idea for #32

Also remove nx caching.

Also adds an error dialog for #8
error

@gjmooney gjmooney marked this pull request as ready for review December 13, 2024 11:48
@jtpio jtpio self-requested a review December 13, 2024 13:43
packages/host/src/index.ts Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@jtpio
Copy link
Collaborator

jtpio commented Dec 13, 2024

Thanks @gjmooney!

I left a couple of inline comments, but it looks good otherwise 👍

Copy link
Collaborator

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 61bd1ad into TileDB-Inc:main Dec 13, 2024
8 checks passed
@gjmooney gjmooney deleted the add_interface branch December 16, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants