Skip to content

Commit

Permalink
Pin Python version in Windows CI. (#5441)
Browse files Browse the repository at this point in the history
Should fix CI failures on GCS.

---
TYPE: NO_HISTORY
  • Loading branch information
teo-tsirpanis authored Feb 6, 2025
1 parent ca7bd07 commit 004f8aa
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/build-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,10 @@ jobs:
uses: seanmiddleditch/gha-setup-ninja@v4
- name: Prevent vcpkg from building debug variants
run: python $env:GITHUB_WORKSPACE/scripts/ci/patch_vcpkg_triplets.py
- name: Install Python
uses: actions/setup-python@v5
with:
python-version: '3.12'

- name: Configure TileDB
shell: pwsh
Expand Down
6 changes: 3 additions & 3 deletions scripts/install-run-gcs-emu.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,9 @@ if (!$RunTestbench) {
Write-Host "Installing Google Cloud Storage Testbench..."
git clone --branch $version --depth 1 https://github.com/googleapis/storage-testbench.git $testbenchPath
Write-Host "Setting up Python virtual environment..."
py -m venv $venvPath
python -m venv $venvPath
& $venvPath\Scripts\activate
py -m pip install -e $testbenchPath
python -m pip install -e $testbenchPath
}
}

Expand All @@ -53,7 +53,7 @@ $env:CLOUD_STORAGE_EMULATOR_ENDPOINT = "http://localhost:9000"
# Run the testbench
& $venvPath\Scripts\activate
# $testbenchCmd = "start `"Google Cloud Storage Testbench`" py testbench_run.py localhost 9000 10"
$testbenchCmd = "start `"Google Cloud Storage Testbench`" /D `"$testbenchPath`" py testbench_run.py localhost 9000 10"
$testbenchCmd = "start `"Google Cloud Storage Testbench`" /D `"$testbenchPath`" python testbench_run.py localhost 9000 10"
cmd /c $testbenchCmd

# Wait for the testbench to be prepared. This was added to fix failures in the windows-2019-gcs job.
Expand Down

0 comments on commit 004f8aa

Please sign in to comment.