Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Optional to Python code that was missing it #443

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

jparismorgan
Copy link
Contributor

What

Here we add Optional to Python code that was missing it. I noticed this b/c VSCode was greying out a code section b/c it was missing somewhere:

Screenshot 2024-07-11 at 3 38 38 PM

Adding this removed the greying out b/c VSCode understood it was optional:

Screenshot 2024-07-11 at 3 38 52 PM

Testing

Tests pass.

@jparismorgan jparismorgan marked this pull request as ready for review July 11, 2024 15:06
@jparismorgan jparismorgan merged commit ed04aee into main Jul 12, 2024
6 checks passed
@jparismorgan jparismorgan deleted the jparismorgan/python-optional branch July 12, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants