Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ids to Python FeatureVectorArray #442

Merged
merged 3 commits into from
Jul 12, 2024

Conversation

jparismorgan
Copy link
Contributor

What

Adds an optional ids argument to the Python FeatureVectorArray. Now you can do:

vectors = np.array([[max_val]], dtype=dtype)
ids = np.array([max_val_ids], dtype=dtype_ids)
feature_vector_array = vspy.FeatureVectorArray(vectors, ids)

And also just:

feature_vector_array = vspy.FeatureVectorArray(vectors, ids)

Testing

  • Adds a unit test
  • In # I am able to update the index using the ids passed in here.

@jparismorgan jparismorgan marked this pull request as ready for review July 11, 2024 19:38
@jparismorgan jparismorgan merged commit 6b05d71 into main Jul 12, 2024
6 checks passed
@jparismorgan jparismorgan deleted the jparismorgan/feature-vector-array-ids branch July 12, 2024 09:02
cainamisir pushed a commit that referenced this pull request Jul 23, 2024
cainamisir pushed a commit that referenced this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants