Fix all MSVC compilation issues #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit af30c0e.
Co-authored-by: Theodore Tsirpanis <theodore.tsirpanis@tiledb.com>
|
This pull request has been linked to Shortcut Story #41344: Re-enable support on Windows. |
dudoslav
commented
Feb 27, 2024
dudoslav
commented
Feb 27, 2024
jparismorgan
approved these changes
Mar 4, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is reopened and merged from main PR: #249
Comments from that PR:
[x] Undo the change to the unit test (i.e., put back uint8_t into the type list)
[x] Remove stdx::filesystem::path and associated header files, as I don't think we are using that any longer?
[x] Make a different change to the template / unique_id change
Note: The previous PR got closed since the merged to branch got deleted (merged into main)
Edit: Wheel producing pipeline is green: https://github.com/dudoslav/TileDB-Vector-Search/actions/runs/8017755596