Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First version of the Object API for vector search #187

Merged
merged 17 commits into from
Jan 29, 2024

Conversation

NikolaosPapailiou
Copy link
Collaborator

@NikolaosPapailiou NikolaosPapailiou commented Jan 10, 2024

First implementation of the Object level API for vector search.

This is using client provided object reader and embedding functions to implement a high level object API.

More details can be found in https://app.shortcut.com/tiledb-inc/story/39895/object-level-api-for-vector-search

@NikolaosPapailiou NikolaosPapailiou changed the title Draft first version of Object API for vector search First version of the Object API for vector search Jan 22, 2024
@NikolaosPapailiou NikolaosPapailiou marked this pull request as ready for review January 22, 2024 15:12
Copy link
Contributor

@jparismorgan jparismorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly minor comments, generally looks good to me. But you may want to wait for another review as well as I may have missed things.

Copy link
Contributor

@jparismorgan jparismorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image_search.ipynb looks good to me as well

@NikolaosPapailiou NikolaosPapailiou merged commit 5b1fa3b into main Jan 29, 2024
5 checks passed
@NikolaosPapailiou NikolaosPapailiou deleted the npapa/object_api branch January 29, 2024 07:22
@NikolaosPapailiou
Copy link
Collaborator Author

@Shelnutt2 comments addressed in #226

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants