-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First version of the Object API for vector search #187
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly minor comments, generally looks good to me. But you may want to wait for another review as well as I may have missed things.
apis/python/src/tiledb/vector_search/embeddings/random_embedding.py
Outdated
Show resolved
Hide resolved
apis/python/src/tiledb/vector_search/embeddings/soma_geneptw_embedding.py
Show resolved
Hide resolved
apis/python/src/tiledb/vector_search/embeddings/soma_geneptw_embedding.py
Outdated
Show resolved
Hide resolved
apis/python/src/tiledb/vector_search/embeddings/soma_geneptw_embedding.py
Outdated
Show resolved
Hide resolved
apis/python/src/tiledb/vector_search/object_api/embeddings_ingestion.py
Outdated
Show resolved
Hide resolved
apis/python/src/tiledb/vector_search/object_api/object_index.py
Outdated
Show resolved
Hide resolved
apis/python/src/tiledb/vector_search/object_readers/bioimage_reader.py
Outdated
Show resolved
Hide resolved
apis/python/src/tiledb/vector_search/object_readers/bioimage_reader.py
Outdated
Show resolved
Hide resolved
apis/python/src/tiledb/vector_search/object_readers/soma_reader.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
image_search.ipynb
looks good to me as well
@Shelnutt2 comments addressed in #226 |
First implementation of the Object level API for vector search.
This is using client provided object reader and embedding functions to implement a high level object API.
More details can be found in https://app.shortcut.com/tiledb-inc/story/39895/object-level-api-for-vector-search