Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework python build system to scikit-build-core #174

Closed

Conversation

dudoslav
Copy link
Collaborator

@dudoslav dudoslav commented Dec 20, 2023

This PR introduces a new way of packaging Python library using scikit-build-core.

Main change had to be to move the pyproject.toml to the top-level folder.

For now we have to include .git in the sdist package, since the src/src/CMakeLists.txt uses git to query version.
In the future we would like to define these values during packaging process.

Also: I'll fix pipelines if this approach is acceptable
Also: This PR concerns tasks 38316 and 38319 as well

@dudoslav dudoslav requested a review from ihnorton December 20, 2023 10:57
@dudoslav dudoslav self-assigned this Dec 20, 2023
@dudoslav dudoslav closed this Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant