Rework python build system to scikit-build-core #174
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new way of packaging Python library using scikit-build-core.
Main change had to be to move the
pyproject.toml
to the top-level folder.For now we have to include
.git
in the sdist package, since thesrc/src/CMakeLists.txt
uses git to query version.In the future we would like to define these values during packaging process.
Also: I'll fix pipelines if this approach is acceptable
Also: This PR concerns tasks 38316 and 38319 as well