Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds nondeterministic and sometimes failing IVF_FLAT unit test #160

Closed
wants to merge 5 commits into from

Conversation

jparismorgan
Copy link
Contributor

@jparismorgan jparismorgan commented Dec 11, 2023

What

Adds a nondeterministic and sometimes failing IVF_FLAT unit test: https://tiledb.slack.com/archives/C0537B4V7Q8/p1702312614334709

@jparismorgan jparismorgan marked this pull request as ready for review December 11, 2023 16:48
@jparismorgan jparismorgan requested a review from lums658 December 11, 2023 17:07
@jparismorgan jparismorgan marked this pull request as draft December 11, 2023 18:02
Copy link
Contributor

@lums658 lums658 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine. Note that the error condition exposed by this test has a fix. In tdb_partitioned_matrix.h add

auto next_part_size = indices_[parts_[i] + 1] - indices_[parts_[i]];

// ADD ME
if (next_part_size == 0) {
  continue;
}

if ((std::get<1>(col_view_) + next_part_size) >
     std::get<0>(col_view_) + max_cols_) {
  break;
}

@jparismorgan
Copy link
Contributor Author

Thanks, I think I will close this PR and re-open it alongside with the fix and some better testing and code setup.

@jparismorgan jparismorgan deleted the py-unit-test branch February 16, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants